JT4 enablement #374

sq6emm · 2024-02-28T22:22:33Z

This is fixing #373

jketterl

Thank you for the pull request. The change looks good overall, just needs a final polishing pass, please see inline comments. Please also check the question about a potential impact on CPU usage by the increase in frequency tolerance. Cheers!

CHANGELOG.md

docker.sh

owrx/modes.py

jketterl · 2024-03-03T14:06:57Z

owrx/wsjt.py

+    def getInterval(self):
+        return 60
+
+    def getSubmode(self):


I don't see this method being used anywhere. Any plans for this? If not, I'd recommend removing it.

It is needed by audio/chopper.py

It isn't. Please remove.

Right... so... I saw the other comment, I believe it went a bit astray. I'm gonna stay on this thread in an attempt to keep things separate.

I also think I see what the issue is here, it's a simple misunderstanding. In pull requests, you usually put comments on the offending line, or the line that best matches the topic to be discussed. In this case, I put the initial comment on the line that has the getSubMode() method signature, trying to tell you that it isn't used.

getInterval() is indeed used, it is part of the AudioChopperProfile API, but I wasn't referring to that one 😉

Corrected;)

owrx/wsjt.py

sq6emm · 2024-06-11T20:11:40Z

@jketterl how do you think, is it now old enough to be merged?:)

jketterl · 2024-06-12T05:58:42Z

Has there been any updates?

sq6emm · 2024-06-12T06:15:34Z

Well I believe for basic functionality nothing more needed? Decoding of JT4 is currently based on the default bandwidth. I also checked as you requested the CPU Increase and described them so you can decide if to implement a possibility to modify the decode bandwidth (that I consider as a feature update)... So well is there anything missing?

jketterl · 2024-06-15T14:08:08Z

Your initial response to the discussion about the -F parameter was:

This is needed capability especially on uWaves where frequencies are not stable enough.

This gave me the impression that being able to control the frequency tolerance was essential to this feature. As such, I did not consider merging this for as long as this setting is not available.

sq6emm · 2024-06-15T16:20:23Z

It's true, but with agile approach it's better to have a MVP;)

sq6emm · 2024-10-16T13:23:53Z

@jketterl any chance to merge it?

jketterl · 2024-10-16T13:24:17Z

Do you see any change? Did you do any changes yourself?

Signed-off-by: Dawid SQ6EMM <[email protected]>

sq6emm · 2025-02-24T15:54:03Z

Hey @jketterl I have added a generic possilbilty for wsjt modes to set frequency tolerance - only interpreted by JT4 now.
Please tell me if its okey for you now - if so I will extended that parameter to all wsjt modes and push.

jketterl · 2025-02-24T15:56:26Z

Looks alright on first glance, but I'd prefer it to be labeled "JT4" both visible and internally. It only applies to JT4 modes (at least that's what I understand, and that's also what I'd expect).

sq6emm · 2025-02-24T15:57:52Z

No, the feature of frequency tolerance is generic to all jt9 related modes.

jketterl · 2025-02-24T15:58:35Z

Ah, now I see, you wanted to extend this to all WSJT-X modes. Any reason to do so? I don't see any problems with the current default, at least not for the existing modes. I feel like this will only cause additional CPU overhead when used, and you'll probably need a separate setting for each mode. Why not limit this to JT4 (where it's needed)?

sq6emm · 2025-02-24T15:59:22Z

Okey, will limit that to JT4 and Q65 if its okey for you?

jketterl · 2025-02-24T15:59:50Z

once again, why Q65?

sq6emm · 2025-02-24T16:01:37Z

both Q65 and JT4 are often used by microwave beacons... where freq stability is not so good.

sq6emm · 2025-02-24T16:29:51Z

Let me be more precise WHY,

common setup to receive 10GHZ with openwebsdr is rtldongle + LNB from SAT TV. LNBs usually dont have stable frequency for SSB and for narrow modes its even more an issue.

Plus on microwaves with digi often beacons are received through rain scatter or air plane scatter - both impacting the receiving frequency. So that frequency tolerance is important on microwaves to compensate those situations.

True, I do not see any usage today beyond JT4 (g) or Q65 (c,d,e) so I would propose I will change this setting to JT4 and Q65 frequency tolerance. And apply that only to those if it will be ok for you.

sq6emm · 2025-03-06T09:04:50Z

@jketterl any comment, suggestion so I can adjust it according to your comfort?

jketterl · 2025-03-07T07:51:08Z

Apologies, I thought I had sent a reply already. Probably typed something and lost it in some buried browser tab.

For general practice, I'd say it would be better to have a separate pull request for Q65, mostly because there should be no depencencies here, I'd say both modes should have an independent setting.

Other than that this looks alright to me.

Signed-off-by: Dawid SQ6EMM <[email protected]>

sq6emm · 2025-03-10T14:42:59Z

Just a kindly reminder;)

jketterl · 2025-03-17T14:25:23Z

owrx/wsjt.py

+    def getInterval(self):
+        return 60
+
+    def getSubmode(self):


It isn't. Please remove.

jketterl · 2025-03-17T14:26:17Z

owrx/wsjt.py

@@ -29,6 +29,13 @@ def decoding_depth(self):
        # default when no setting is provided
        return 3

+    def jt4_frequency_tolerance(self):


This has no business being on WsjtProfile if it's only used in Jt4Profile. Please move.

getInterval is used - as this mode is decoded every 60 seconds, if removed:

Traceback (most recent call last): File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner self.run() File "/opt/openwebrx/owrx/audio/chopper.py", line 59, in run self.setup_writers() File "/opt/openwebrx/owrx/audio/chopper.py", line 48, in setup_writers sorted_profiles = sorted(self.profile_source.getProfiles(), key=lambda p: p.getInterval()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/openwebrx/owrx/wsjt.py", line 79, in getProfiles return [JT4Profile(i) for i in profiles if i in JT4Profile.availableSubmodes] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/openwebrx/owrx/wsjt.py", line 79, in <listcomp> return [JT4Profile(i) for i in profiles if i in JT4Profile.availableSubmodes] ^^^^^^^^^^^^^ TypeError: Can't instantiate abstract class JT4Profile with abstract method getInterval

This has no business being on WsjtProfile if it's only used in Jt4Profile. Please move.

Corrected.

jketterl · 2025-03-17T14:35:07Z

Also, I just ran this with on an rtl-sdr with no real reception. There's nothing on the waterfall. Yet, for some reason, I have empty decodes showing up in the receiver. I'm not sure if this is false positives, or some kind of quirk of the JT4 decoder, but if possible, this should be accounted for.

sq6emm · 2025-03-18T21:54:58Z

Also, I just ran this with on an rtl-sdr with no real reception. There's nothing on the waterfall. Yet, for some reason, I have empty decodes showing up in the receiver. I'm not sure if this is false positives, or some kind of quirk of the JT4 decoder, but if possible, this should be accounted for.

This is happening due to strange jt9 behaviour. I confirmed it also using recordings from owrx outside of containers on my local computer:

$ jt9 -4 -b G copy-openwebrx-audiochopper-126863547833744-250318_2144.wav
2144 -26  4.3 1488 $
<DecodeFinished>   0   1        0

this is with just background noise
copy-openwebrx-audiochopper-126863547833744-250318_2144.wav.gz

I have asked for it on wsjt group. (https://wsjtx.groups.io/g/main/message/55445)

Signed-off-by: Dawid SQ6EMM <[email protected]>

jketterl · 2025-03-19T12:32:40Z

Thanks for inquiring about the empty messages. Let's see what comes out of it. I'm not subscribed to that mailing list, so feel free to ping here if there's any updates.

Signed-off-by: Dawid SQ6EMM <[email protected]>

sq6emm · 2025-03-20T12:50:20Z

I suggest we leave it as it is - native behaviour.
Unless you have another idea @jketterl ? (script that will parse the output)

sq6emm · 2025-03-20T14:58:37Z

This is the proposed script that will replace jt9 command for jt4 (if you think it make sense)

Characters that need to be taken into account as end of message are: f, fN, dCN - not only "f" like in an example. Following wsjt-x Use Guide - 13.2 Decoded Lines Table 5 (Notations used on decoded text lines).

cat jt9-4wrap.sh 
#!/bin/bash

jt9 ${@} | egrep -e 'f  $' -e '^<'

and output of execuction:

$ ./jt9-4wrap.sh -4 -b G -d 3 -F 1000 openwebrx-audiochopper-126863547460368-250318_2137.wav
<DecodeFinished>   0   1        0

$ ./jt9-4wrap.sh -4 -b G -d 3 -F 1000 openwebrx-audiochopper-126863547460368-250318_2138.wav
2138 -14 -0.6  888 $* SR6LEG JO81CE          f 
<DecodeFinished>   0   1        0

unless you prefer to leave it untouched.

I have an idea how to do the same inside of WsjtParser() - but first decision needed how it should behave;)

jketterl · 2025-03-20T17:41:13Z

Well, I'm afraid I don't think that adding a script for this purpose makes sense. Not only does this add a new dependency (egrep), there's also the problem of how to distribute that script.

If you want to filter those messages I recommend having a look at the existing parser code inside OpenWebRX.

You have a new reply by Joe Taylor now to explain what those messages are.

Signed-off-by: Dawid SQ6EMM <[email protected]>

sq6emm · 2025-03-20T18:11:35Z

Ok, now it does not bother us with empty messages

sq6emm · 2025-03-25T19:54:25Z

Do we miss anything yet?

JT4 enablement

c16ec8e

jketterl reviewed Mar 3, 2024

View reviewed changes

Dawid SQ6EMM added 2 commits March 3, 2024 20:19

JT4 fixes according to jkettler suggestions

cde00a0

getInterval is needed by audio/chopper.py

d494a59

sq6emm closed this Oct 16, 2024

jketterl reopened this Oct 16, 2024

sq6emm added 2 commits February 24, 2025 15:54

Merge branch 'jketterl:develop' into develop

14087c2

Add possibility to set frequency tolerance (initial for jt4 only)

f8fb178

Signed-off-by: Dawid SQ6EMM <[email protected]>

Add possibility to set frequency tolerance (initial for jt4 only)

6e6100f

Signed-off-by: Dawid SQ6EMM <[email protected]>

jketterl reviewed Mar 17, 2025

View reviewed changes

Made frequency tolerance local to JT4 class

965287b

Signed-off-by: Dawid SQ6EMM <[email protected]>

Removed unused getSubode

d4d4f72

Signed-off-by: Dawid SQ6EMM <[email protected]>

Remove empty JT4 messages (be design of JT4 decoder)

cf7b81f

Signed-off-by: Dawid SQ6EMM <[email protected]>

JT4 enablement #374

Are you sure you want to change the base?

JT4 enablement #374

Conversation

sq6emm commented Feb 28, 2024

jketterl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sq6emm Mar 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sq6emm commented Jun 11, 2024

jketterl commented Jun 12, 2024

sq6emm commented Jun 12, 2024

jketterl commented Jun 15, 2024

sq6emm commented Jun 15, 2024 • edited Loading

sq6emm commented Oct 16, 2024

jketterl commented Oct 16, 2024

sq6emm commented Feb 24, 2025 • edited Loading

jketterl commented Feb 24, 2025

sq6emm commented Feb 24, 2025

jketterl commented Feb 24, 2025

sq6emm commented Feb 24, 2025

jketterl commented Feb 24, 2025

sq6emm commented Feb 24, 2025

sq6emm commented Feb 24, 2025

sq6emm commented Mar 6, 2025

jketterl commented Mar 7, 2025

sq6emm commented Mar 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jketterl commented Mar 17, 2025

sq6emm commented Mar 18, 2025 • edited Loading

jketterl commented Mar 19, 2025

sq6emm commented Mar 20, 2025 • edited Loading

sq6emm commented Mar 20, 2025 • edited Loading

jketterl commented Mar 20, 2025

sq6emm commented Mar 20, 2025

sq6emm commented Mar 25, 2025

sq6emm Mar 3, 2024 •

edited

Loading

sq6emm commented Jun 15, 2024 •

edited

Loading

sq6emm commented Feb 24, 2025 •

edited

Loading

sq6emm commented Mar 18, 2025 •

edited

Loading

sq6emm commented Mar 20, 2025 •

edited

Loading

sq6emm commented Mar 20, 2025 •

edited

Loading