Fixed:correct the calculation of quorum in learner #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to fix some issues. Please wait to merge this pull request. |
Currently, Learner accumulates the vote when booth runs renew. the number of vote exceeds the total of acceptor after a little. And then, booth always has the quorum. booth use multi-paxos to implement renew. however, booth still dosn't "instance number". "instance number" can resolve this issue. And, when this was fixed, the other problem also happened. Regardless of learner reach a quorum, booth can't commit a value when a proposer message is lost. In terms of Paxos, this should commit a value. So, we move the making of timer to learner(or proposer) from acceptor. Signed-off-by: Yuichi SEINO <[email protected]>
Currently, booth can't recover instance number when booth was fail-over on local. So, booth can't keep ticket when booth run renews after fail-over. we propose the following way. booth can get a ballot by catch. So, booth first run the full-round paxos when booth run renew after fail-over. booth boosts a round. And, booth resets instance number. And then, booth run the normal renew. Signed-off-by: Yuichi SEINO <[email protected]>
|
I updated this pull request. |
|
Are there any comments about those commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learner accumulates the vote when booth runs renew.
the number of vote exceeds the total of acceptor after a little.
And then, booth always has the quorum.
I consult the following wiki.
http://en.wikipedia.org/wiki/Paxos_%28computer_science%29
I think that booth implements renew() by using Multi-Paxos. However, booth still doesn't implement the instance number I(ref wiki). So, I add the instance number to paxos message. Learner can discerns a acceptor message in the same round. And, booth can calculate the correct vote number.