Skip to content

Conversation

glehmann
Copy link
Contributor

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

A user-facing distinction between templates and template-aliases doesn't
seem functionally significant. Combining them makes a more streamlined
and less confusing user experience.
@glehmann glehmann force-pushed the gln/config-move-template-aliases-nnso branch from 04c9441 to 30e052f Compare August 19, 2025 18:56
@yuja
Copy link
Contributor

yuja commented Aug 20, 2025

A bigger problem we'll need to solve is how we can apply the same rule to revset-aliases and revsets. Because tags and bookmarks are symbols in revset, we shouldn't define any symbol aliases by default. This is less of an issue in templates, but the user might not want to make their namespace polluted by random <command-name> aliases.

@glehmann
Copy link
Contributor Author

Indeed, that doesn't seem like a good idea for the revsets, and we probably want to use the same method for configuring the templates and the revsets…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants