Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the timestamps from jigasi #542

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

rpurdel
Copy link
Contributor

@rpurdel rpurdel commented Aug 20, 2024

No description provided.

oanaianc
oanaianc previously approved these changes Aug 20, 2024
@rpurdel rpurdel requested a review from damencho August 20, 2024 12:31
@rpurdel rpurdel changed the title [DO NOT MERGE] fix: set the timestamps from jigasi fix: set the timestamps from jigasi Aug 20, 2024
@damencho
Copy link
Member

This will not give correct results as sometimes the results can be not in the correct order - partial and final results.
We had similar problem in google transcriptions where we were creating the timestamp ids on receiving the results. We needed to move it to when the audio is being received, before sent to the transcriber service, this way the timestamped ids are guranteed to be in correct order as this is the time when audio is received in jigasi.

@rpurdel rpurdel requested a review from oanaianc August 22, 2024 08:46
@rpurdel
Copy link
Contributor Author

rpurdel commented Aug 22, 2024

This will not give correct results as sometimes the results can be not in the correct order - partial and final results. We had similar problem in google transcriptions where we were creating the timestamp ids on receiving the results. We needed to move it to when the audio is being received, before sent to the transcriber service, this way the timestamped ids are guranteed to be in correct order as this is the time when audio is received in jigasi.

The Whisper backend always returns the transcriptions in the correct order.

damencho
damencho previously approved these changes Aug 22, 2024
@damencho
Copy link
Member

Can you rebase as ot has conflicts

@damencho damencho merged commit c53ba86 into jitsi:master Aug 22, 2024
2 checks passed
@rpurdel rpurdel deleted the whisper-timestamps-to-jigasi branch August 22, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants