fix for targetextension
config option
#25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Premake you can specify the option to change target file's extension like this:
targetextension ".aes"
This would cause the check I fixed to fail, as the extension isn't
.dll
. Not sure if my fix for this is perfect, but I don't think MSVC can build non-Windows libraries, so it should be fine?This fails the gcc test though, but honestly I don't have any better ideas for now. But for now better to partially fix than not at all, unless you have any better ideas...