-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rplace JSON with YAML #26
base: master
Are you sure you want to change the base?
Conversation
fix apache log always output "common" fix set host issue
Hello @absszero, |
clamp.defaults.13.yaml
Outdated
autoopen: false | ||
errorlog: "{{$cwd}}/.clamp/logs/apache.error.log" | ||
customlog: "{{$cwd}}/.clamp/logs/apache.access.log" | ||
pidfile: "'{{$cwd}}/.clamp/tmp/httpd.pid'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you wrap the pid file here in single quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were single quotes in the original JSON file. I converted it to YAML and kept it.
@absszero Your code looks good! If you answer my three questions, I can merge your code. Also: Did you take SpyC from github (mustangostang/spyc)? Next step: |
Hey folks, Thanks for your contribution @absszero, it's cool to see other people contributing to the project ! Funnily, I think that if there are two entries, one being I'm a little worried because YAML will break existing setups. So that would be a breaking change. Until now, nobody seemed to have the need of multiple In an ideal world we would allow both JSON and YAML so that nothing breaks. But I know this would need some extra work, and I myself don't have the time to work on this. @rqelibari What do you think ? EDIT: That said, the YAML config looks much cleaner than JSON and seems much more natural. |
@rqelibari The contribution guideline and the dev branch sound like a good idea ! |
@rqelibari Yes, I took it from mustangostang/spyc. |
I tried to set up vhosts in clamp.json, but JSON does not support multiple-lines. and duplicate key is not allowed, for example,
"<Directory"
.So I replace JSON with YAML and build a temporary Apache configure file, then start Apache with the configure file.