Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #953

Open
wants to merge 54 commits into
base: dev
Choose a base branch
from
Open

Bugfixes #953

wants to merge 54 commits into from

Conversation

Felioh
Copy link
Contributor

@Felioh Felioh commented May 16, 2024

This fixes some inconsistencies with the XRay API:

I suspect the source of these bugs is somewhere else since the documentation (and this client?) is generated?

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Copy link
Contributor

github-actions bot commented May 16, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Felioh
Copy link
Contributor Author

Felioh commented May 16, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the WatchRecipients is fine, I don't think the other change is needed.

xray/services/report.go Show resolved Hide resolved
@Felioh
Copy link
Contributor Author

Felioh commented Aug 13, 2024

don't think the other change is needed

What other change?

@attiasas
Copy link
Contributor

don't think the other change is needed

What other change?

The Due Diligance (License) report contains the license key in a json-field named 'license_key' not 'license'. https://jfrog.com/help/r/xray-rest-apis/get-due-diligence-report-content (Also incorrect in the documentation)

so the right attribute is license_key no need to change

@Felioh Felioh requested a review from attiasas September 2, 2024 08:32
@Felioh
Copy link
Contributor Author

Felioh commented Nov 13, 2024

Is there a reason, why this hasn't been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants