Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Git Repository Url as Xray Scan Graph param #1039

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Add Git Repository Url as Xray Scan Graph param #1039

wants to merge 17 commits into from
+92 −34

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 7, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Add options to pass Git Repository Url to act as a violation context (similar to project, watches...)
Param was introduced at Xray version 3.106.2: https://jfrog-int.atlassian.net/browse/XRAY-89943

@attiasas attiasas added the improvement Automatically generated release notes label Nov 7, 2024
@attiasas attiasas mentioned this pull request Nov 7, 2024
Open
7 tasks
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@attiasas attiasas marked this pull request as ready for review November 10, 2024 13:15
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 24, 2024
orz25
orz25 reviewed Nov 25, 2024
View reviewed changes
xray/services/scan.go Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 25, 2024
This was referenced Nov 25, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orz25 orz25 orz25 left review comments

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @orz25