-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Yarn
Version and Improve Error Messaging for Unsupported Versions
#2866
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the test cases to address new changes made to the other PRs.
Also i'm editing the PR title, as CLI pull requests will appear in the release notes of the CLI, and this is the place to notify users about the improvement that has been introduced here. ( also by the core and artifactory )
Yarn
Version and Improve Error Messaging for Unsupported Versions
@@ -41,4 +41,6 @@ jobs: | |||
RTLIC: ${{ secrets.RTLIC }} | |||
|
|||
- name: Run npm tests | |||
env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is required since yarn4 is not compatible with node16, this env will allow yarn4 tests to run in the same env.
Note: upgrading node16 to node18 causes legacyNpm tests to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all the yarn v4 tests now that we removed the support for yarnv4 commands?
dev
branch.go vet ./...
.go fmt ./...
.depends on:-
Yarn
version jfrog-cli-core#1347