Issue #12806 - Overhaul ComplianceViolation.Listener reporting

[joakime]

Cleanup all code paths that perform a ComplianceViolation check to do the following ...

• Always report the violation, if detected.
• Report if the violation was allowed (or not)
• Use the HttpChannelState.getCompliaceViolationListener() in all cases (this gets the benefit of a single ComplianceViolation.Listener to use, along with all of the initialize(), onRequestBegin(), and onRequestEnd() techniques.
• Deprecate the HttpConfiguration notify methods
• Deprecate the ComplianceViolation.notify() static methods.

Closes #12806

[gregw]

Looking better, but still work to do.

Very out of date review.
Using @sbordet for review.

[sbordet]

I'd prefer the *Assert methods to be removed, as they don't add anything, and they're as verbose as just calling allowed()/notifyAndCheck() plus throwing.

[joakime]

so you want to go from ...

if (checkCompliance(compliance, violation1, detail, error))
{
   // do allowed part for violation1
} 
else if (checkCompliance(compliance, violation2, detail, error))
{
   // do allowed part for violation2
}

to

if (allowed(compliance, violation1))
{
   // do allowed part for violation1
} 
else 
{
   throw error(violation1, detail)
}

if (allowed(compliance, violation2))
{
  // do allowed part for violation2
} 
else 
{
  throw error(violation2, detail)
}

That's going to blossom the lines of code a significant bit

[lorban]

BadMessageException is deprecated and has been replaced by HttpException.RuntimeException.