Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Standalone API server with integration tests #365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented May 17, 2018

  • Tried to separate out the API server options that require kubernetes API configuration options.
  • Don't apply those command line options if --standalone-mode has been supplied.
  • Added a wrapper around the Kubernetes integration test framework to also launch the Navigator API server and connect it to the same Etcd server.
  • Currently parses stderr to check for a successful startup message, but the API server ought to have an /healthz endpoint.

Fixes: #364

Release note:

NONE

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wallrj wallrj force-pushed the 364-apiserver-integration-tests branch from 7807d64 to 47da2ce Compare May 17, 2018 18:59
@wallrj wallrj changed the title WIP: Standalone API server with integration tests Standalone API server with integration tests May 17, 2018
* Tried to separate out the API server options that require kubernetes API configuration options.
* Don't apply those command line options if `--standalone-mode` has been supplied.
* Added a wrapper around the Kubernetes integration test framework to also launch the Navigator API server and connect it to the same Etcd server.
* Currently parses stderr to check for a successful startup message, but the API server ought to have an `/healthz` endpoint.

Fixes: jetstack#364

Hook up a navigator cli helper
@jetstack-bot
Copy link
Collaborator

@wallrj: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants