Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

WIP: Add script to update example manifests #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kragniz
Copy link
Contributor

@kragniz kragniz commented Feb 28, 2018

Fixes #260.

NONE

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@kragniz
Copy link
Contributor Author

kragniz commented Feb 28, 2018

This currently only updates the cassandra example. The elasticsearch example a bit more different from the manifest used in e2e tests, so I haven't added it yet.

/cc @munnerz

@jetstack-bot
Copy link
Collaborator

@kragniz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
navigator-e2e-v1-7 bbb0b72 link /test e2e v1.7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@munnerz
Copy link
Contributor

munnerz commented Mar 1, 2018

We also need a corresponding verify script here.

FWIW, as I've said before, I do not think our e2e tests should only be driven by docs. Instead, we should have tests for the things in our docs (i.e. using sphinx's testing features), but the e2e test suite should test more advanced features which may or may not make sense to include in our documentation.

@jetstack-bot
Copy link
Collaborator

@kragniz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants