Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pmad.Milsymbol to display ORBATs #52

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Use Pmad.Milsymbol to display ORBATs #52

merged 1 commit into from
Jan 18, 2025

Conversation

jetelain
Copy link
Owner

No description provided.

@jetelain jetelain requested a review from Copilot January 18, 2025 12:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Arma3TacMapWebApp/Arma3TacMapWebApp.csproj: Language not supported
Comments suppressed due to low confidence (4)

Arma3TacMapWebApp/Entities/OrbatUnit.cs:72

  • [nitpick] The property name 'HigherFormation' suggests it should return an identifier for a higher formation, but it always returns an empty string. Consider renaming it or providing a meaningful implementation.
string? IOrbatUnit.HigherFormation => string.Empty;

Arma3TacMapWebApp/Views/Orbats/Details.cshtml:28

  • Ensure that Model.Owner is not null before using the ! operator.
@Html.DisplayFor(model => model.Owner!.UserLabel)

Arma3TacMapWebApp/Views/Orbats/Details.cshtml:53

  • Ensure that Model.Units is not null before using the ! operator.
@Html.DisplayNameFor(model => model.Units![0].UniqueDesignation)

Arma3TacMapWebApp/Views/Orbats/Details.cshtml:74

  • Ensure that the generated PNG is handled properly and that the height calculation is correct.
<img src="data:image/png;base64,@Convert.ToBase64String(png)" height="@(symbol.Height/2)" alt="@sdic" />
@jetelain jetelain merged commit e13cabe into main Jan 18, 2025
1 check passed
@jetelain jetelain deleted the orbat-display branch January 18, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant