Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(draft): custom folder to avoid repetitions with __mocks__ #14338

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

scarletquasar
Copy link

@scarletquasar scarletquasar commented Jul 18, 2023

Summary

Implement customMocks folder feature to avoid __mocks__ folder repetition in monorepos or similar situations (see issue #13647).

Work in progress.

Test plan

  • current tests are passing
  • add units tests
  • add e2e tests
  • add type tests
  • documentation

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 30f5000
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64b61a9b5b901c000897545a
😎 Deploy Preview https://deploy-preview-14338--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scarletquasar scarletquasar changed the title feat: custom folder to avoid repetitions with __mocks__ feat(draft): custom folder to avoid repetitions with __mocks__ Jul 18, 2023
Copy link

@noghartt noghartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

'__mocks__',
);
// eslint-disable-next-line no-console
console.log(options?.customMockPath);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this console.log?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a draft so I didn't remove these checkers yet

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, okay, nice

@scarletquasar
Copy link
Author

Just remembering that this PR is not forgotten. Im just having a though time in the work and my time is strictly limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants