Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to typescript #391

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: migrate to typescript #391

wants to merge 4 commits into from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 16, 2022

Why not 馃榾

I have no idea if the global types still work. They should.

@SimenB SimenB requested a review from thymikee August 16, 2022 12:24
serializers = customSerializers;
}

module.exports = snapshotDiff;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change, btw

@thymikee
Copy link
Member

Tested globals extending jest object on a sample project with snapshot-diff linked and it didn't work. I wonder how would it work if root index.d.ts is not referenced by tsconfig nor package.json now. I tried moving namespace declaration to build/index.d.ts directly and it doesn't make a difference. I'm out of ideas for now :D

@thymikee
Copy link
Member

Just leaving this here for future reference :P https://github.com/facebook/jest/pull/13195/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants