Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When using
toReject
/toResolve
, print more detailed failure reason (e.g. whentoResolve
gets a rejected promise, the rejection value will be printed for easier troubleshooting (as discussed in #322 and #218)Why
Often when refactoring code tested using
toResolve
ortoReject
, the test fails but it's unclear on why since the resolved or rejection values are not displayed as a part of the test-failure outout.This PR adds:
toResolve
receives a rejected promise.not.toResolve
receives a resolved promisetoReject
receives a resolved promise.not.toReject
receives a rejected promise.Notes
This does not change the beahvior of
toResolve
ortoReject
in any way, but only adds extra info on falitures.Housekeeping