Add prefer-spy-on rule #191
Conversation
| output: "jest.spyOn(Date, 'now')", | ||
| }, | ||
| { | ||
| code: "obj['prop' + 1] = jest['fn']()", |
There was a problem hiding this comment.
could you add a test using template strings as well?
There was a problem hiding this comment.
I added a test for window[`${name}`] = jest.fn(). window.name = jest[`fn`]() doesn't trigger a warning though because i'm using util.getNodeName which ignores TemplateLiterals.
Another test, that I know of, that doesn't handle TemplateLiterals is no-identical-title. This doesn't trigger warning:
test("name", () =>{})
test(`name`, () => {})Should they though?
There was a problem hiding this comment.
Yeah, I think they should. At least if there's no concatenation or interpolation
There was a problem hiding this comment.
I added a TemplateLiteral case to util.getNodeName. This also adds TemplateLiteral support for some other rules which i could add tests for. But maybe in another pull request?
There was a problem hiding this comment.
Separate PR fleshing out other tests would be great!
|
@hanneslund hmm, on master, it says line 112 is not covered by tests, mind checking it out? |
|
@SimenB yeah sure! |
|
I added 1047c9c as a quickfix |
Feedback welcome, especially the docs and error message.
Closes #185