Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update codecov/codecov-action action to v4 #1494

Merged
merged 15 commits into from May 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 31, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
codecov/codecov-action action major v3 -> v4

Release Notes

codecov/codecov-action (codecov/codecov-action)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Contributor Author

renovate bot commented Feb 2, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting 500 errors...

image

Will create a reminder to come back in a week to take a new look

@SimenB
Copy link
Member

SimenB commented Feb 29, 2024

still getting 500 errors

@SimenB
Copy link
Member

SimenB commented Apr 6, 2024

new error: Upload failed: {"detail":"Github OIDC Token Auth: Invalid token."} - weird. I don't understand how they messed up the action so bad 😅

@SimenB
Copy link
Member

SimenB commented Apr 16, 2024

Same OIDC error now.

@G-Rath
Copy link
Collaborator

G-Rath commented Apr 25, 2024

Wanted to have a quick go as I seemed to have gotten v4 working over in google/osv-scanner#941 though that be related to my PR there being from a fork which Codecov has said don't need a token.

At least now CI is failing to reflect its still broken 😄

@G-Rath G-Rath force-pushed the renovate/codecov-codecov-action-4.x branch from ef5b8c8 to c715c0d Compare April 25, 2024 22:12
@G-Rath
Copy link
Collaborator

G-Rath commented Apr 29, 2024

@SimenB I really hate asking but since I'm now talking to Codecov about this for osv-scanner I figure best to just get this out of the way as they're going to ask until I do: are you absolutely sure the right token is correctly set in secrets against CODECOV_TOKEN?

@SimenB
Copy link
Member

SimenB commented Apr 29, 2024

Not certain at all 😃 Currently at a concert, but I can update it tonight (or tomorrow if it gets too late 😅)

@thomasrockhu-codecov
Copy link

I don't understand how they messed up the action so bad 😅

Sorry about that, there were more moving pieces than we anticipated and definitely some edge cases that we were missing. Just wanted to pop in and say I'm taking a look at this

@SimenB
Copy link
Member

SimenB commented Apr 30, 2024

I forgot, but updated the token now.

I don't understand how they messed up the action so bad 😅

Sorry about that, there were more moving pieces than we anticipated and definitely some edge cases that we were missing. Just wanted to pop in and say I'm taking a look at this

No worries - I've definitely been there myself! Sorry about the snark.

@SimenB
Copy link
Member

SimenB commented May 12, 2024

@SimenB
Copy link
Member

SimenB commented May 12, 2024

Ah, it's a --coverage false which fails as it doesn't find files. That seem very fair

@SimenB
Copy link
Member

SimenB commented May 12, 2024

This PR is not from a fork tho, so if codecov/feedback#358 is an issue, that'll only be known after landing

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it, and revert if it causes issues for forks

🤞

@SimenB SimenB merged commit c5ebd4e into main May 12, 2024
36 of 37 checks passed
@SimenB SimenB deleted the renovate/codecov-codecov-action-4.x branch May 12, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants