Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock reporting #3550

Merged
merged 1 commit into from May 15, 2024
Merged

Fix deadlock reporting #3550

merged 1 commit into from May 15, 2024

Conversation

stefanhaller
Copy link
Collaborator

Deadlock reporting broke in e1ceb68 (last September); since then, it was off when running debug builds normally, but on when debugging an integration test. Both of which are exactly opposite of what we want.

Deadlock reporting broke in e1ceb68; since then, it was *off* when running
debug builds normally, but *on* when debugging an integration test. Both of
which are exactly opposite of what we want.
@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label May 5, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -2.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (618fe53) 50753 42728 84.19%
Head commit (10e29ce) 50753 (+0) 42737 (+9) 84.21% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3550) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanhaller stefanhaller merged commit ac0524f into master May 15, 2024
17 checks passed
@stefanhaller stefanhaller deleted the fix-deadlock-reporting branch May 15, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance For refactorings, CI changes, tests, version bumping, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants