Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking in status side panel #3547

Merged
merged 2 commits into from May 15, 2024
Merged

Conversation

stefanhaller
Copy link
Collaborator

  • PR Description

Clicking in the status side panel should activate it; also, clicking on the repo name should bring up the recent repositories menu, and clicking on the "(rebasing)" text should bring up the rebase options menu. All of this was broken for a long time, since somewhere around the big refactoring of March 2023. (The exact commit where it broke is hard to bisect, since many of the commits in that area either don't compile or crash at startup...)

I'm fixing this not because I think it's super important functionality (nobody seems to have missed it for over a year), but because I have to touch this code in another PR, and noticed that it wasn't working.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller stefanhaller added the bug Something isn't working label May 3, 2024
Copy link

codacy-production bot commented May 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -2.00%) 98.11%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ac0524f) 50753 42730 84.19%
Head commit (380855d) 50798 (+45) 42807 (+77) 84.27% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3547) 53 52 98.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work on the tests

Seems to have been broken since that big refactoring in March 23.
To prevent this from breaking again. All three tests would fail without the fix
from the previous commit.
@stefanhaller stefanhaller merged commit 5558d87 into master May 15, 2024
13 of 14 checks passed
@stefanhaller stefanhaller deleted the fix-clicking-in-status-panel branch May 15, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants