feat: Improve install script with error handling and robustness #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add error checking for failed downloads/API requests using set -e - Use proper GitHub API parsing instead of fragile sed extraction - Better architecture/OS detection and mapping - Add user feedback messages and progress reporting - Ensure target directory creation before installation - Verify successful extraction before installation This enhances reliability, handles edge cases better, and improves the user experience during installation/updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Improvements:
1, Error Handling:
set -estops execution on errors.2, Robust Version Parsing:
grep -oPto extract the tag from GitHub’s API (still avoids jq dependency).3, User Feedback:
4, Directory Creation:
mkdir -pto avoid issues.