Skip to content

Conversation

@inochisa
Copy link

@inochisa inochisa commented Aug 7, 2025

Description

Introduce basic category support for qBittorrent.

These PR still have some gaps:

  1. The category can not be created directly in flood.
  2. The savepath of category is not applied when setting category.
  3. The category setting is not applied for feed torrents.

Related Issue

#686

Screenshots

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@inochisa inochisa force-pushed the qbittorrent-categories branch from 872e960 to 9aebf88 Compare August 7, 2025 07:59
@trim21
Copy link
Collaborator

trim21 commented Aug 7, 2025

I'll merge this PR with squash, please do not force-push

@inochisa
Copy link
Author

inochisa commented Aug 7, 2025

I'll merge this PR with squash, please do not force-push

Sorry, I will do not do this again. Thanks for your reminder.

export interface TorrentProperties {
bytesDone: number;
comment: string;
category: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure this is not nullable or defined?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be nullable, as '' can be used to identify no category.

@trim21
Copy link
Collaborator

trim21 commented Oct 21, 2025

The savepath of category is not applied when setting category

this involve the torrent auto manage feature in the qb and it's a little bit complicated, for now I think make category visible/filterable but not changeable in floold maybe a good idea. we can add these things later.

@inochisa
Copy link
Author

this involve the torrent auto manage feature in the qb and it's a little bit complicated, for now I think make category visible/filterable but not changeable in floold maybe a good idea. we can add these things later.

Good to know, I will update the code and add minimum features. Thanks

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

❌ Patch coverage is 58.95522% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.06%. Comparing base (15f7d23) to head (6eb18ca).
⚠️ Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
...erver/services/qBittorrent/clientRequestManager.ts 11.76% 15 Missing ⚠️
server/routes/api/torrents.ts 60.00% 14 Missing ⚠️
server/services/taxonomyService.ts 65.71% 12 Missing ⚠️
server/services/Deluge/clientGatewayService.ts 37.50% 5 Missing ⚠️
...erver/services/qBittorrent/clientGatewayService.ts 69.23% 4 Missing ⚠️
...rver/services/Transmission/clientGatewayService.ts 75.00% 2 Missing ⚠️
server/services/rTorrent/clientGatewayService.ts 75.00% 2 Missing ⚠️
server/services/feedService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   73.08%   73.06%   -0.02%     
==========================================
  Files          66       66              
  Lines       11533    11674     +141     
  Branches      987      990       +3     
==========================================
+ Hits         8429     8530     +101     
- Misses       3088     3144      +56     
+ Partials       16        0      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants