-
Notifications
You must be signed in to change notification settings - Fork 167
feat: Add basic Category Support for qBittorrent #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Inochi Amaoto <[email protected]>
Signed-off-by: Inochi Amaoto <[email protected]>
Signed-off-by: Inochi Amaoto <[email protected]>
872e960 to
9aebf88
Compare
|
I'll merge this PR with squash, please do not force-push |
Sorry, I will do not do this again. Thanks for your reminder. |
| export interface TorrentProperties { | ||
| bytesDone: number; | ||
| comment: string; | ||
| category: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure this is not nullable or defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be nullable, as '' can be used to identify no category.
client/src/javascript/components/torrent-list/TorrentListContextMenu.tsx
Show resolved
Hide resolved
this involve the |
Good to know, I will update the code and add minimum features. Thanks |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 73.08% 73.06% -0.02%
==========================================
Files 66 66
Lines 11533 11674 +141
Branches 987 990 +3
==========================================
+ Hits 8429 8530 +101
- Misses 3088 3144 +56
+ Partials 16 0 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Introduce basic category support for qBittorrent.
These PR still have some gaps:
Related Issue
#686
Screenshots
Types of changes