Improve location info for syntax errors. #4816
Conversation
zherczeg
force-pushed
the
syntax_error
branch
8 times, most recently
from
b27ea39 to
e07af28
Compare
|
Patch is ready for review. |
zherczeg
force-pushed
the
syntax_error
branch
from
e07af28 to
82df616
Compare
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
syntax_error
branch
from
82df616 to
048874e
Compare
| } | ||
| } | ||
|
|
||
| return jerry_throw (ecma_raise_type_error (ECMA_ERR_MSG ("Location is not available"))); |
There was a problem hiding this comment.
I'm wondering wether it would be better to simply return with undefined if there is no location, or with a pre-defined magic string. And similarly when error messages are disabled.
It feels to me like the location info is an added bonus, it can be used when it's available, but if it's not, then that's not really a problem. Or at least not something that would warrant an error.
| * error, otherwise | ||
| */ | ||
| jerry_value_t | ||
| jerry_get_syntax_error_location (jerry_value_t value, /**< SyntaxError object */ |
There was a problem hiding this comment.
How about not making this syntax error specific, and changing the name to be generic for errors. Functionally it already seems to be generic. Also in the future we could possibly include location info for other error types as well.
Same for the jerry_syntax_error_location_t type, I would just call it jerry_error_location_t.
|
@zherczeg please rebase |
No description provided.