Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SKIP LOCKED for MariaDB 10.6+. #2150

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

simi
Copy link
Contributor

@simi simi commented Apr 5, 2024

Should be supported according to https://mariadb.com/kb/en/select/#skip-locked. I have tested locally and it works well. I wasn't able to find out any specs to cover this.

@jeremyevans
Copy link
Owner

Thanks for the patch! There are integration tests for this, so I should be able to test tomorrow if it works. I think GitHub CI is MySQL and not MariaDB, so GitHub CI wouldn't be able to test this.

@simi
Copy link
Contributor Author

simi commented Apr 5, 2024

Thanks for the patch! There are integration tests for this, so I should be able to test tomorrow if it works. I think GitHub CI is MySQL and not MariaDB, so GitHub CI wouldn't be able to test this.

I have tested locally with version() = 10.11.5-MariaDB-1:10.11.5+maria~ubu1804-log. Indeed current GitHub Actions is MySQL only.

@jeremyevans jeremyevans merged commit 917d0e6 into jeremyevans:master Apr 5, 2024
16 checks passed
@simi simi deleted the patch-1 branch April 7, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants