Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite adapter - allow create_table with :without_rowid option #2126

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

loranger32
Copy link
Contributor

@loranger32 loranger32 commented Jan 25, 2024

Proposal to add support for the sqlite WITHOUT ROWID table option in the sqlite adapter.

@loranger32 loranger32 changed the title sqlite adapter - allow create_table with :without_row_id option sqlite adapter - allow create_table with :without_rowid option Jan 25, 2024
@jeremyevans
Copy link
Owner

Failing tests look unrelated, probably due to internal changes in SQLite 3.45.0 (:id value in some json functions). I'll see if I can address those failures.

@loranger32
Copy link
Contributor Author

Thanks, FWIW I ran the tests with SQLite 3.42.0 (latest version available on Ubuntu 23.10 official repository).

@jeremyevans jeremyevans merged commit 5cd7be7 into jeremyevans:master Jan 25, 2024
11 of 16 checks passed
@loranger32
Copy link
Contributor Author

Thanks !

@loranger32 loranger32 deleted the sqlite_without_row_id branch January 25, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants