Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor configured :top option for empty lists #2115

Conversation

johanmagnusson
Copy link
Contributor

Using the list plugin with the option :top set to something other than the default (1) is causing discrepancies when adding a new element to an empty list without providing a specific position value. The plugin will always set the start value to 1 and ignore the configured top option.

This PR will make the list plugin honor the configured top option when the first item in the list is added when the position value is not provided.

This will make the list plugin honor the configured :top option
when the first item in the list is added when the position value
is not provided.
@jeremyevans
Copy link
Owner

Thanks for the patch! I agree this is a bug and the fix looks good.

@jeremyevans jeremyevans merged commit 570c3f5 into jeremyevans:master Jan 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants