Make optimistic_locking plugin not keep lock column in changed_column…

…s after updating instance
jeremyevans · Jul 29, 2024 · d6f4faa · d6f4faa
1 parent 48f3ce6
commit d6f4faa
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,7 @@
 === master
 
+* Make optimistic_locking plugin not keep lock column in changed_columns after updating instance (jeremyevans) (#2196)
+
 * Have defaults_setter plugin pass model instance to default_values callable if it has arity 1 (pedrocarmona) (#2195)
 
 * Support string_agg extension on SQLite 3.44+ (segiddins) (#2191)

diff --git a/lib/sequel/plugins/optimistic_locking.rb b/lib/sequel/plugins/optimistic_locking.rb
@@ -45,6 +45,8 @@ def _update_columns(columns)
           columns[lc] = lcv + 1
           super
           set_column_value("#{lc}=", lcv + 1)
+          changed_columns.delete(lc)
+          nil
         end
       end
     end

diff --git a/spec/extensions/optimistic_locking_spec.rb b/spec/extensions/optimistic_locking_spec.rb
@@ -124,4 +124,11 @@
     proc{p1.save_changes}.must_raise(RuntimeError)
     p1.lock_version.must_equal lv
   end
+
+  it "should not marked the lock column changed after saving" do
+    p1 = @c[1]
+    p1.modified!
+    p1.save_changes
+    p1.changed_columns.must_be_empty
+  end
 end