Respect :skip_transaction option in PostgreSQL Dataset#paged_each (Fixes

 #2097)

This turns on the hold option, which does have effects beyond just
not using a transaction, but you cannot use a non-HOLD cursor
outside of a transaction.

CHANGELOG

@@ -1,5 +1,7 @@
 === master
 
+* Respect :skip_transaction option in PostgreSQL Dataset#paged_each (jeremyevans) (#2097)
+
 * Add TimestampMigrator.run_single to run a single migration file up or down (opya, jeremyevans) (#2093)
 
 * Support INSERT RETURNING on MariaDB 10.5+, and use it when saving new model objects (jeremyevans)

lib/sequel/adapters/postgres.rb

@@ -672,6 +672,7 @@ def paged_each(opts=OPTS, &block)
  # cursor usage.
  # :rows_per_fetch :: The number of rows per fetch (default 1000). Higher
  # numbers result in fewer queries but greater memory use.
+ # :skip_transaction :: Same as :hold, but :hold takes priority.
  #
  # Usage:
  #
@@ -764,13 +765,13 @@ def call_procedure(name, args)
 
  # Use a cursor to fetch groups of records at a time, yielding them to the block.
  def cursor_fetch_rows(sql)
- server_opts = {:server=>@opts[:server] || :read_only}
  cursor = @opts[:cursor]
- hold = cursor[:hold]
+ hold = cursor.fetch(:hold){cursor[:skip_transaction]}
+ server_opts = {:server=>@opts[:server] || :read_only, :skip_transaction=>hold}
  cursor_name = quote_identifier(cursor[:cursor_name] || 'sequel_cursor')
  rows_per_fetch = cursor[:rows_per_fetch].to_i
 
- db.public_send(*(hold ? [:synchronize, server_opts[:server]] : [:transaction, server_opts])) do 
+ db.transaction(server_opts) do 
  begin
  execute_ddl("DECLARE #{cursor_name} NO SCROLL CURSOR WITH#{'OUT' unless hold} HOLD FOR #{sql}", server_opts)
  rows_per_fetch = 1000 if rows_per_fetch <= 0