Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformed fixed issues presentation. #736

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ private Object createNewDetailView(final String link, final Run<?, ?> owner, fin
labelProvider.getLinkName(), url, labelProvider, sourceEncoding);
}
if ("fixed".equalsIgnoreCase(link)) {
return new FixedWarningsDetail(owner, result, fixedIssues, url, labelProvider, sourceEncoding);
return new IssuesDetail(owner, result, fixedIssues, EMPTY, EMPTY,
fixedIssues, Messages.Fixed_Warnings_Header(), url, labelProvider, sourceEncoding);
}
if ("new".equalsIgnoreCase(link)) {
return new IssuesDetail(owner, result, newIssues, newIssues, EMPTY,
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ void shouldThrowExceptionIfLinkIsNotFound() {
}

@Test
void shouldReturnFixedWarningsDetailWhenCalledWithFixedLink() {
FixedWarningsDetail details = createTrendDetails("fixed", RUN, createResult(),
void shouldReturnFixedIssuesDetailWhenCalledWithFixedLink() {
IssuesDetail details = createTrendDetails("fixed", RUN, createResult(),
ALL_ISSUES, NEW_ISSUES, OUTSTANDING_ISSUES, FIXED_ISSUES, ENCODING, createParent(),
FixedWarningsDetail.class);
IssuesDetail.class);
assertThat(details).hasIssues(FIXED_ISSUES);
assertThat(details).hasFixedIssues(FIXED_ISSUES);
assertThat(details).hasNewIssues(NO_ISSUES);
Expand Down

This file was deleted.