-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect pkg.jenkins.io to install doc page instead of brief summary #431
base: master
Are you sure you want to change the base?
Redirect pkg.jenkins.io to install doc page instead of brief summary #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the other content on the page being retained if it will not be readable after the redirect?
I decided to leave the remaining content as is to ensure the HTML templating scripts/functions wouldn't break. At the moment, I'm not well versed to the codebase so I'd like to add incremental change before understanding it further to remove the HTML templating apparatus and subsequently, the page's contents. |
The content should be removed at the same time that the redirect is being introduced. As-is, this PR is not ready for merge. |
I've pushed new commits to clean up unused content as redirection is added. This is the
It'll redirect to aforementioned link afterwards. For other installation platform, here are their respective redirection URL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this migration losing information? I don't see any references to tzdata-java
on https://www.jenkins.io/doc/book/installing/linux/, but I see them (deleted) in this PR.
I checked with Rocky Linux 8 using the installation instructions from https://www.jenkins.io/doc/book/installing/linux/#red-hat-centos and when I enter the command I haven't checked Rocky Linux 9, but I assume that if |
<pre class="text-white bg-dark"> | ||
<code> | ||
sudo apt-get update | ||
sudo apt-get install fontconfig openjdk-17-jre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the reference to fontconfig
on https://www.jenkins.io/doc/book/installing/linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. Added to the Debian documentation in jenkins-infra/jenkins.io#6721
|
||
<pre class="text-white bg-dark"> | ||
|
||
sudo zypper addrepo -f {{web_url}}/ {{artifactName}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the reference to zypper
on https://www.jenkins.io/doc/book/installing/linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will need a larger addition to the installation section of the documentation. There isn't a section for openSUSE installation yet. I'll need to check with @kmartens27 to see if he's available to work on an openSUSE section for the documentation.
|
||
<pre class="text-white bg-dark"> | ||
|
||
yum install fontconfig java-17-openjdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the reference to fontconfig
on https://www.jenkins.io/doc/book/installing/linux?
<dt>2.419 (August 2023) and newer</dt> | ||
<dd>Java 11, Java 17, or Java 21</dd> | ||
|
||
<dt>2.357 (June 2022) and newer</dt> | ||
<dd>Java 11 or Java 17</dd> | ||
|
||
<dt>2.164 (February 2019) and newer</dt> | ||
<dd>Java 8 or Java 11</dd> | ||
|
||
<dt>2.54 (April 2017) and newer</dt> | ||
<dd>Java 8</dd> | ||
|
||
<dt>1.612 (May 2015) and newer</dt> | ||
<dd>Java 7</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this information on https://www.jenkins.io/doc/book/installing/war-file/?
Testing
Here's the generated
index.html
once runmake publish
.Jenkins Debian Packages
This is the Debian package repository of Jenkins to automate installation and upgrade.
To use this repository, first add the key to your system:
Then add a Jenkins apt repository entry:
Update your local package index, then finally install Jenkins:
The apt packages were signed using this key:
The page immediately redirects to https://www.jenkins.io/doc/book/installing/linux/, can be locally reproduced as well
Implements #415
Submitter checklist