Remove 'Disable project' button from project view

[janfaracik]

Discussed briefly in the last UX Sig, the 'Disable project' (and 'Add/edit description') button take up a lot of vertical space (roughly 100px) and this forces useful information, such as stage view plugin etc down.

My proposal would be just to remove the 'Disable project' button altogether and instead have users rely on the configure screen to disable projects.

Before

After

Testing done

• Disable button has been removed, still possible to reenable a project from that view however

Proposed changelog entries

• Remove 'Disable project' button from project view.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. The Jira issue, if it exists, is well-described.

   The Jira issue, if it exists, is well-described.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

   The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. There is automated testing or an explanation as to why this change has no tests.

   There is automated testing or an explanation as to why this change has no tests.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

   New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

   New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

   New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.

   For dependency updates, there are links to external changelogs and, if possible, full differentials.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
8. For new APIs and extension points, there is a link to at least one consumer.

   For new APIs and extension points, there is a link to at least one consumer.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title

Beta Give feedback Tasklist Maintainer checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.

   There are at least two (2) approvals for the pull request and no outstanding requests for change.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

   Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

   Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Proper changelog labels are set so that the changelog can be generated automatically.

   Proper changelog labels are set so that the changelog can be generated automatically.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

   If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

   If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Maintainer checklist

[uhafner]

I never used that button on my own, but wouldn't it make sense to remove it when we move all those actions to the action bar?

[timja]

I never used that button on my own, but wouldn't it make sense to remove it when we move all those actions to the action bar?

This button is also on the configure page so its just duplicated so I think its a special case.

[daniel-beck]

Isn't this a good use case for app-bar buttons?

[janfaracik]

I never used that button on my own, but wouldn't it make sense to remove it when we move all those actions to the action bar?

Isn't this a good use case for app-bar buttons?

I agree with Tim here, this is a duplicated button that isn't very often used for how prominent it is. Demoed an app bar rework for the project page in the latest UX meeting in which it could live, but not sure how useful it would be to have there.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!