Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-72744] remove tooltip when widget is refreshed #9201

Merged
merged 1 commit into from May 4, 2024
Merged

[JENKINS-72744] remove tooltip when widget is refreshed #9201

merged 1 commit into from May 4, 2024
+1 −1

Conversation

mawinter69
Copy link
Contributor

Attach the tooltip to the parent element instead of the document body. When a widget is refreshed, the elements are deleted. But the tooltip stays when it is added to the body and thus will never be able to receive an event when the mouse is moved out. Only by clicking somewhere the tooltip disappears
By attaching it to the parent, when the widget is refreshed and the content is removed this will automatically also remove the tooltip html elements.

See JENKINS-72744.

Testing done

Manual testing

Start a build and hover over the progress bar in the build history or on the dashboard in the executors widget. After a few seconds you will notice a flicker and the tooltip text is updated. The old tooltip is removed.

Proposed changelog entries

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@mawinter69
[JENKINS-72744] remove tooltip in widget refresh
c6d76c2 
Attach the tooltip to the parent element instead of the document body.
When a widget is refreshed, the elements are deleted. But the tooltip
stays when it is added to the body and thus will never be able to
receive an event when the mouse is moved out.
By attaching it to the parent, when the widget is refreshed and the
content is remobed this will automatically also remove the tooltip html
elements.
@mawinter69
Copy link
Contributor Author

@janfaracik Could this have any side effects when the tooltip is attached to the parent and not the body?
I couldn't find any, but maybe there are in special situations.

@NotMyFault NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Apr 29, 2024
@NotMyFault NotMyFault requested a review from a team April 29, 2024 08:21
daniel-beck
daniel-beck approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well. Flicker is preferable to stacking IMO.

@NotMyFault
Copy link
Member

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 30, 2024
@NotMyFault NotMyFault merged commit 884f7e5 into jenkinsci:master May 4, 2024
16 checks passed
@mawinter69
Copy link
Contributor Author

Caused https://issues.jenkins.io/browse/JENKINS-73158

@mawinter69
Copy link
Contributor Author

fixed with #9263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

@janfaracik janfaracik Awaiting requested review from janfaracik

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Milestone
No milestone
4 participants
@mawinter69 @NotMyFault @daniel-beck @timja