Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-70822] Improve plugin manager search #9137

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[JENKINS-70822] Improve plugin manager search #9137

wants to merge 4 commits into from
+119 −28

Conversation

timja
Copy link
Member

@timja timja commented Apr 6, 2024 •
edited

See JENKINS-70822.

Consider multiple words rather than just doing sub string match

build token can now match build-token-root
Pipeline Groovy, can now match Pipeline: Groovy.

I had to implement a basic ranking algorithm in order for this to be usable as without it they appeared in the middle somewhere or even not in first 50 in some cases.

I restricted the multiple word search to just name and title as a lot of these words show up in the description.

Open to feedback :)

Testing done

Unit tests + searches in the UI especially the searches from the Jira ticket

Proposed changelog entries

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Apr 6, 2024
@timja timja requested review from a team and daniel-beck April 6, 2024 22:38
@daniel-beck
Copy link
Member

daniel-beck commented Apr 9, 2024 •
edited

Thanks for taking care of this!

First quick test has an unexpected result when searching for workflow cps though, with Pipeline: Groovy (and really any relevant plugin) way down:

Screenshot 2024-04-09 at 13 21 25

Similarly, pipeline cps has several Pipeline-related results first, before showing Pipeline: Groovy. Is the weight given to matching all tokens perhaps too low? (Or perhaps even only show results not matching all terms if there is no hit for all terms?)

@BobDu
Copy link
Member

BobDu commented Apr 15, 2024

Looks this PR will has conflict with #9162

Can we first merge #9162 into master, and then update this PR branch use master.
Because #9162 it's just a simple fix to restore the behavior before the code was refactored.

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 18, 2024
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck Awaiting requested review from daniel-beck

Assignees
No one assigned
Labels
rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted unresolved-merge-conflict There is a merge conflict with the target branch.
Projects
None yet
Milestone
No milestone
3 participants
@timja @daniel-beck @BobDu