Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-72803]: Disable agent name "(built-in)" #9128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-72803]: Disable agent name "(built-in)" #9128

wants to merge 1 commit into from

Conversation

Lmh-java
Copy link
Contributor

@Lmh-java Lmh-java commented Apr 5, 2024

See JENKINS-72803.
This issue aims to resolve [JENKINS-72803].

Since "(built-in)" is a default agent name in Jenkins, if user creates another agent with this name, Jenkins will recognize them as the same one and user cannot operate the created one.

After investigating this issue, it is more feasible and efficient for us to ban "(built-in)" to be used as an agent name. Enforcing the system to distinguish the original built-in agent and the user-created agent can be problematic with low ROI.

Since "%" is already banned, so we don't need to worry about URL encoding bypass.

Screenshot (After):

When user wants to create a new agent with name "(built-in)":
image
image

Testing done

  1. Manual testing:
    a. If I create an agent with name "(built-in)", system will reject due to invalid name.
    b. variations such as "(Built-in)", "(bUILT-in)", "XXX (built-in)" are tested and did not produce problems.
  2. Light test

Proposed changelog entries

Remove JENKINS-72803 if there is no issue for the pull request.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@NotMyFault NotMyFault requested a review from a team April 5, 2024 21:23
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Apr 9, 2024
@MarkEWaite MarkEWaite changed the title [Jenkins-72803]: Disable agent name "(built-in)" [JENKINS-72803]: Disable agent name "(built-in)" Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Milestone
No milestone
2 participants
@Lmh-java @MarkEWaite