Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify label to 'Jenkins user database' #9024

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Simplify label to 'Jenkins user database' #9024

wants to merge 1 commit into from

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Mar 8, 2024 •
edited

Thoughts about this simplification in the label?

Pros:

Cons:

  • It could more easily be confused with security realm as a term ("My Jenkins user database is LDAP").

Testing done

config screenshot breadcrumb screenshot

Proposed changelog entries

  • JENKINS-XXXXX, human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@daniel-beck daniel-beck mentioned this pull request Mar 8, 2024
Draft
@MarkEWaite
Copy link
Contributor

I am "+1" for the change. I think the benefits are worth the change.

@StefanSpieker
Copy link
Contributor

I am +1 for adjusting, we could also rename it to internal user database - I think the word Jenkins is of no use there.

timja
timja reviewed Apr 6, 2024
View reviewed changes
core/src/main/resources/hudson/security/Messages.properties
@@ -25,7 +25,7 @@ GlobalSecurityConfiguration.Description=Secure Jenkins; define who is allowed to
HudsonPrivateSecurityRealm.WouldYouLikeToSignUp=This {0} {1} is new to Jenkins. Would you like to sign up?
LegacyAuthorizationStrategy.DisplayName=Legacy mode

HudsonPrivateSecurityRealm.DisplayName=Jenkins’ own user database
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Stefan in #9024 (comment).
Jenkins is unneeded, I'm not a huge fan of user database though, but I could live with it.

What about one of these?

Suggested change
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
HudsonPrivateSecurityRealm.DisplayName=Local authentication
Suggested change
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
HudsonPrivateSecurityRealm.DisplayName=Internal
Suggested change
HudsonPrivateSecurityRealm.DisplayName=Jenkins user database
HudsonPrivateSecurityRealm.DisplayName=Local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@daniel-beck @MarkEWaite @StefanSpieker @timja