Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop shipping commons-lang3 #8997

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Stop shipping commons-lang3 #8997

merged 1 commit into from
Mar 1, 2024

Conversation

basil
Copy link
Member

@basil basil commented Feb 27, 2024

#8971 inadvertently began bundling commons-lang3 in the WAR, something we do not want to do because we do not want to increase core's API surface area. Instead we prefer to rely on a library plugin to deliver this to consumers in the Jenkins plugin ecosystem. This library is only used in org.apache.commons.compress.harmony.unpack200.Pack200UnpackerAdapter, which we don't use anyway, so we can simply exclude commons-lang3 without any negative effects. See also apache/commons-compress#489.

Testing done

Built Jenkins and verified the WAR no longer contains commons-lang3.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@NotMyFault NotMyFault requested a review from a team February 28, 2024 21:20
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 28, 2024
@NotMyFault NotMyFault merged commit db29f34 into jenkinsci:master Mar 1, 2024
17 checks passed
@basil basil deleted the lang3 branch March 4, 2024 19:53
@basil
Copy link
Member Author

basil commented Mar 4, 2024

COMPRESS-669 FTR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants