discussion: Lint Jelly files?

[janfaracik]

For discussion purposes -

How do we feel about linting Jelly? Currently nigh every other file is linted in Jenkins and this works well. I'd propose including Jelly in that too, I've tweaked .prettierrc to include Jelly files and the output seems to be quite sensible.

@jenkinsci/sig-ux

[janfaracik]

Set printWidth fairly high otherwise attributes get split onto new lines, e.g.

<st:compress 
  xmlns:j="jelly:core" 
  xmlns:st="jelly:stapler" 
  xmlns:d="jelly:define" 
  xmlns:l="/lib/layout" 
  xmlns:t="/lib/hudson" 
  xmlns:f="/lib/form" 
  xmlns:i="jelly:fmt">

I don't personally find this beneficial (at least for namespace declarations).

[NotMyFault]

No objections from me, if linting works consistently 👍

[timja]

Fine with me if you can get a green build

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[timja]

The linting is breaking something

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[janfaracik]

So the tests are failing as certain xpath selectors are no longer valid due to the whitespace changes, e.g. Add parameter is now Add parameter.

This can be fixed by setting htmlWhitespaceSensitivity to strict, see https://prettier.io/docs/en/options.html#html-whitespace-sensitivity and https://prettier.io/blog/2018/11/07/1.15.0#whitespace-sensitive-formatting. This brings its own issues however as it seems to be mangling rss20.jelly and it's also no longer as opinionated.

[timja]

So the tests are failing as certain xpath selectors are no longer valid due to the whitespace changes, e.g. Add parameter is now Add parameter.

This can be fixed by setting htmlWhitespaceSensitivity to strict, see prettier.io/docs/en/options.html#html-whitespace-sensitivity and prettier.io/blog/2018/11/07/1.15.0#whitespace-sensitive-formatting. This brings its own issues however as it seems to be mangling rss20.jelly and it's also no longer as opinionated.

This normally fixes xpath that is that sensitive: https://developer.mozilla.org/en-US/docs/Web/XPath/Functions/normalize-space

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!