Skip to content

Replaced deprecated methods with recommended alternatives #11018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+12 −4
Open

Replaced deprecated methods with recommended alternatives #11018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8d2634
ANTLRException is deprecated, document recommends using IllegalArgume…
Pushkar-Mahajan4 Aug 28, 2025
30e6a66
IOUtils.toString(final InputStream input) deprecated, replaced with t…
Pushkar-Mahajan4 Aug 28, 2025
9ede66e
Replace IOUtils.toString()
Pushkar-Mahajan4 Aug 30, 2025
9b57e6e
Revert to ANTLRException since some plugins might break
Pushkar-Mahajan4 Aug 30, 2025
8d5b003
Remove additional whitespace
Pushkar-Mahajan4 Aug 30, 2025
97eb143
Formatting fix
Pushkar-Mahajan4 Sep 1, 2025
eed0574
Remove defaultCharset Argument
Pushkar-Mahajan4 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/java/hudson/os/WindowsUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
import hudson.Functions;
import java.io.File;
import java.io.IOException;
import java.nio.charset.Charset;
import java.util.Arrays;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import org.apache.commons.io.IOUtils;

/**
* Utilities for the Windows Platform.
Expand Down Expand Up @@ -119,8 +119,8 @@ public class WindowsUtil {
Process mklink = execCmd("mklink", "/J", junction.getAbsolutePath(), target.getAbsolutePath());
int result = mklink.waitFor();
if (result != 0) {
String stderr = IOUtils.toString(mklink.getErrorStream());
String stdout = IOUtils.toString(mklink.getInputStream());
String stderr = new String(mklink.getErrorStream().readAllBytes());
String stdout = new String(mklink.getInputStream().readAllBytes());
throw new IOException("Process exited with " + result + "\nStandard Output:\n" + stdout + "\nError Output:\n" + stderr);
}
return junction;
Expand Down
10 changes: 9 additions & 1 deletion core/src/main/java/hudson/scheduler/CronTabList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public synchronized boolean check(Calendar cal) {
public String checkSanity() {
for (CronTab tab : tabs) {
String s = tab.checkSanity();
if (s != null) return s;
if (s != null) return s;
}
return null;
}
Expand Down Expand Up @@ -118,6 +118,10 @@ public static CronTabList create(@NonNull String format, Hash hash) {
if (timezone != null) {
LOGGER.log(Level.CONFIG, "CRON with timezone {0}", timezone);
} else {
/*
* @deprecated use {@link IllegalArgumentException}
* Some plugins might not catch : IllegalArgumentException & break
*/
throw new ANTLRException("Invalid or unsupported timezone '" + timezoneString + "'");
}
continue;
Expand All @@ -128,6 +132,10 @@ public static CronTabList create(@NonNull String format, Hash hash) {
try {
r.add(new CronTab(line, lineNumber, hash, timezone));
} catch (IllegalArgumentException e) {
/*
* @deprecated use {@link IllegalArgumentException}
* Some plugins might catch : IllegalArgumentException & break
*/
throw new ANTLRException(Messages.CronTabList_InvalidInput(line, e.getMessage()), e);
}
}
Expand Down