Skip to content

Conversation

ridemountainpig
Copy link
Contributor

@ridemountainpig ridemountainpig commented Aug 27, 2025

Use the same styling for title bar mouse over effect.
See JENKINS-75990.

Testing done

Before
CleanShot 2025-08-27 at 14 54 13@2x

After
CleanShot 2025-08-27 at 14 59 14@2x

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label web-ui

Proposed upgrade guidelines

  • Use the same styling for title bar mouse over effect

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@ridemountainpig
Copy link
Contributor Author

/label web-ui

@comment-ops-bot comment-ops-bot bot added the web-ui The PR includes WebUI changes which may need special expertise label Aug 27, 2025
@krisstern krisstern requested review from janfaracik, timja and a team August 27, 2025 12:03
@krisstern krisstern added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Aug 27, 2025
@uhafner
Copy link
Member

uhafner commented Aug 27, 2025

Thanks for creating this PR! I think the colors and the border already look correct. What is missing: the height of the breadcrumb (the textual part) is not the same as the height of the buttons and the sidebar. Can this be adjusted as well?

@ridemountainpig
Copy link
Contributor Author

Thanks for creating this PR! I think the colors and the border already look correct. What is missing: the height of the breadcrumb (the textual part) is not the same as the height of the buttons and the sidebar. Can this be adjusted as well?

I’ve adjusted the breadcrumb height so it now matches the buttons and the sidebar. Thank you.

CleanShot 2025-08-28 at 00 06 18@2x

@janfaracik
Copy link
Member

Hey, just on leave at the moment but I'll take a look at this.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the fix!

@uhafner
Copy link
Member

uhafner commented Aug 27, 2025

Do you have an idea (not in this PR) how we can add a hover effect for the Jenkins logo as well? The hover effect for this part of the breadcrumb is almost invisible right now.

@ridemountainpig
Copy link
Contributor Author

Do you have an idea (not in this PR) how we can add a hover effect for the Jenkins logo as well? The hover effect for this part of the breadcrumb is almost invisible right now.

Sure, I can try adding a hover effect for the Jenkins logo in another PR.

@janfaracik
Copy link
Member

Thanks -

Not a fan of the increased height, I don't think that the breadcrumbs need to match the height of the buttons on the other side of the screen, seeing as breadcrumbs are just text vs icons.

Also, in regards to the Jenkins logo - would support decreasing the opacity further on hover, but I'm not sure how we could apply this background to it without it looking off. The reason for not having the background on the breadcrumbs in the first place was for consistency with the logo.


Not blocking - would be good to fix whilst in this space:

image

@ridemountainpig
Copy link
Contributor Author

image

@janfaracik I have updated it. @uhafner, what do you think about the breadcrumb height?
Arc 2025-09-02 21 34 03

@uhafner
Copy link
Member

uhafner commented Sep 2, 2025

Well, for me it is a matter of symmetry. So I personally prefer the same height. It already looks weird that the height of the chevron overlay is different.

But this is not a blocker for me. Jan is the designer, he probably knows better what to do... what think other people?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants