Skip to content

Conversation

StefanSpieker
Copy link
Contributor

@StefanSpieker StefanSpieker commented Aug 17, 2025

Migrated configureclouds redirect from groovy to jelly. If you think, deleting the redirect is even better, I'm also fine doing this.

Testing done

started jenkins in debug and verified that redirect is working from configureClouds to /manage/cloud

I also used a curl command curl -vL to verify that it is working:

grafik

Proposed changelog entries

  • N/A

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added the skip-changelog Should not be shown in the changelog label Aug 17, 2025
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think, deleting the redirect is even better, I'm also fine doing this.

It's a redirect since #7658 in 2.403, probably safe to delete at this point. Thoughts @Vlatombe ?


<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler">
<st:redirect url="../manage/cloud/" />
Copy link
Member

@daniel-beck daniel-beck Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also used a curl command curl -vL to verify that it is working:

Due to .. use here instead of rootURL as before (and the insanity coming from #6126), the result is a little awkward with /manage/configureClouds which was the most likely URL though which the old configuration was accessed.

Screenshot 2025-08-17 at 22 29 20
Suggested change
<st:redirect url="../manage/cloud/" />
<st:redirect url="../cloud/" />

is probably a better approach, as it should neither add nor remove /manage/ (untested).

@Vlatombe
Copy link
Member

probably safe to delete at this point

I guess it shouldn't matter anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants