-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[JENKINS-75581] Improve create-view cli command to create a view inside a folder #10632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[JENKINS-75581] Improve create-view cli command to create a view inside a folder #10632
Conversation
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
@@ -38,6 +41,7 @@ | |||
public class CreateViewCommand extends CLICommand { | |||
|
|||
@Argument(usage = "Name of the view to use instead of the one in XML") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make it explicit here that any /
in the name will be used to put the view into a folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback.
I have improved the description of the arguments.
Please take a moment and address the merge conflicts of your pull request. Thanks! |
…older_using_jenkins_cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryohsuket please resolve conflicts for this PR.
@A1exKH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@daniel-beck |
See JENKINS-75581.
Testing done
Proposed changelog entries
Proposed changelog category
/label rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).