apply suggestions from code review

jenkinsci · Apr 9, 2024 · 3aa9d08 · 3aa9d08
1 parent 30ce180
commit 3aa9d08
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java
@@ -53,7 +53,19 @@
 import hudson.search.SearchItems;
 import hudson.security.ACL;
 import hudson.tasks.LogRotator;
-import hudson.util.*;
+import hudson.util.AlternativeUiTextProvider;
+import hudson.util.ChartUtil;
+import hudson.util.ColorPalette;
+import hudson.util.CopyOnWriteList;
+import hudson.util.DataSetBuilder;
+import hudson.util.DescribableList;
+import hudson.util.FormApply;
+import hudson.util.Graph;
+import hudson.util.ProcessTree;
+import hudson.util.RunList;
+import hudson.util.ShiftedCategoryAxis;
+import hudson.util.StackedAreaRenderer2;
+import hudson.util.TextFile;
 import hudson.widgets.HistoryWidget;
 import hudson.widgets.HistoryWidget.Adapter;
 import hudson.widgets.Widget;
@@ -108,7 +120,9 @@
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.args4j.Argument;
 import org.kohsuke.args4j.CmdLineException;
-import org.kohsuke.stapler.*;
+import org.kohsuke.stapler.StaplerOverridable;
+import org.kohsuke.stapler.StaplerRequest;
+import org.kohsuke.stapler.StaplerResponse;
 import org.kohsuke.stapler.export.Exported;
 import org.kohsuke.stapler.interceptor.RequirePOST;
 import org.kohsuke.stapler.verb.POST;

diff --git a/core/src/main/java/hudson/model/TopLevelItemDescriptor.java b/core/src/main/java/hudson/model/TopLevelItemDescriptor.java
@@ -287,7 +287,7 @@ public static ExtensionList<TopLevelItemDescriptor> all() {
  }
 
  @Restricted(NoExternalUse.class)
- public static FormValidation doCheckDisplayNameOrNull(@AncestorInPath AbstractProject<?, ?> project, @QueryParameter String value) {
- return Jenkins.get().doCheckDisplayName(value, project.getName());
+ public FormValidation doCheckDisplayNameOrNull(@AncestorInPath TopLevelItem item, @QueryParameter String value) {
+ return Jenkins.get().doCheckDisplayName(value, item.getName());
  }
 }