Migrate from maven-artifact-transfer to direct use of Resolver API
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@basil, please take a look It would be great to close this as part of Hacktoberfest |
olamy
approved these changes
Oct 28, 2024
basil
changed the title
maven-artifact-transfer to direct use of Resolver API
basil
added a commit
to jenkinsci/stapler-maven-plugin
that referenced
this pull request
Oct 28, 2024
basil
added a commit
to jenkinsci/stapler-maven-plugin
that referenced
this pull request
Oct 28, 2024
…ed2 to 195.v4662dd79fdb_d (#124) * Bump io.jenkins.tools.maven:jellydoc-maven-plugin Bumps [io.jenkins.tools.maven:jellydoc-maven-plugin](https://github.com/jenkinsci/jellydoc-maven-plugin) from 190.ve454d5e0ced2 to 195.v4662dd79fdb_d. - [Release notes](https://github.com/jenkinsci/jellydoc-maven-plugin/releases) - [Commits](https://github.com/jenkinsci/jellydoc-maven-plugin/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.maven:jellydoc-maven-plugin dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Adapt to jenkinsci/jellydoc-maven-plugin#118 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Basil Crow <[email protected]>
|
@pyatizbyantsevia It's superfluous to say that we're grateful for you cleaning up this old Maven plugin. If you're interested in another ticket like this, jenkinsci/maven-hpi-plugin#511 is still open. If not, then thanks again for this contribution! |
|
I want to express my gratitude to everyone involved! It was an interesting experience =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
Testing done
I tested the plugin in action by running a simple project that reflects how it works: https://github.com/pyatizbyantsevia/jellydoc-maven-plugin-64
Submitter checklist
Other
I'm not sure if using RepositoryUtils methods is a good idea. The description of this class contains the following comment:
Warning: This is an internal utility class that is only public for technical reasons, it is not part of the public API. In particular, this class can be changed or deleted without prior notice.