Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test module + joda time #682

Closed
wants to merge 2 commits into from

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Oct 18, 2021

in some scenarios joda time version is required because different
plugins pull different versions.

Require upper bound dependencies error for joda-time:joda-time:2.10.2 paths to dependency are:
+-io.jenkins.tools.bom:sample:999999-SNAPSHOT
  +-org.jenkins-ci.plugins:dashboard-view:2.17
    +-joda-time:joda-time:2.10.2
and
+-io.jenkins.tools.bom:sample:999999-SNAPSHOT
  +-io.jenkins.configuration-as-code:test-harness:1.54
    +-com.github.erosb:everit-json-schema:1.13.0
      +-com.damnhandy:handy-uri-templates:2.1.8
        +-joda-time:joda-time:2.10.2 (managed) <-- joda-time:joda-time:2.10.10
and
+-io.jenkins.tools.bom:sample:999999-SNAPSHOT
  +-org.jenkinsci.plugins:pipeline-model-definition:1.9.2
    +-org.jenkinsci.plugins:pipeline-model-api:1.9.2
      +-com.github.fge:json-schema-validator:2.0.4
        +-joda-time:joda-time:2.10.2 (managed) <-- joda-time:joda-time:2.1

On the kubernetes plugin for example, I don't have dashboard-view and the two others (pipeline-model-extensions and io.jenkins.configuration-as-code:test-harness) conflict.

I was planning initially to convert the sample-plugin to an its, however since the current logic to set up pct highly depends on it and I wasn't sure of what I was doing, I preferred to keep it as is.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

in some scenarios joda time version is required because different
plugins pull different versions.
@jglick
Copy link
Member

jglick commented Oct 18, 2021

joda time version is required because different plugins pull different versions

Then a library wrapper module should be introduced.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to include random libraries here—only plugins.

@jglick
Copy link
Member

jglick commented Oct 18, 2021

Filing #683 for the IT thing. I would like to replace sample-plugin, not just augment it.

@Vlatombe
Copy link
Member Author

Fine

@Vlatombe Vlatombe closed this Oct 18, 2021
@MarkEWaite
Copy link
Contributor

I thought that Joda time was considered obsolete with Java 8 and later. In those cases where we have capacity to do so, shouldn't we push to replace Joda time with JSR-310 as included in Java 8?

@timja
Copy link
Member

timja commented Oct 20, 2021

Yes joda-time shouldn’t be used anymore, but depends on if dependencies will remove it

@Vlatombe
Copy link
Member Author

From the tree above it could probably be cleaned up from dashboard-view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants