Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-build weekly instead of manually #3640

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

darinpope
Copy link
Contributor

Build once a week instead of requiring a manually launched build. This will help as we onboard more BOM maintainers since some won't have Job.BUILD access on ci.jenkins.io.

Testing done

Verified with pipeline syntax generator

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@darinpope darinpope marked this pull request as ready for review September 26, 2024 19:57
@darinpope darinpope requested a review from a team as a code owner September 26, 2024 19:57
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work even if the main branch is not locked?

@MarkEWaite MarkEWaite merged commit fafadec into jenkinsci:master Sep 26, 2024
5 checks passed
@darinpope darinpope deleted the build-weekly branch September 26, 2024 20:23
@jglick jglick added the chore Reduces future maintenance label Sep 26, 2024
@MarkEWaite
Copy link
Contributor

This morning I remembered why we hadn't used this technique earlier. When building a release of the plugin BOM, we need to lock the master branch so that pull requests from plugin releases are not merged during the build. When a pull request is merged, it will cancel the release job that is running.

I've enabled branch protection on the master branch now that the build is running and will create and pin the issue for the release.

@timja
Copy link
Member

timja commented Sep 27, 2024

This morning I remembered why we hadn't used this technique earlier. When building a release of the plugin BOM, we need to lock the master branch so that pull requests from plugin releases are not merged during the build. When a pull request is merged, it will cancel the release job that is running.

I've enabled branch protection on the master branch now that the build is running and will create and pin the issue for the release.

Easily do-able with a scheduled action that locks the branch that runs before the Jenkins job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants