Add Jira Test Result Reporter to the managed set #3606 #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed to modify `check.groovy` to remove the sorting because of uppercase issues. SInce we're now using spotless, we were getting into a doom loop sort ordering.
basil
added
the
full-test
timja
reviewed
Sep 26, 2024
| def sortedDeps = managedPluginDeps.toSorted { a, b -> | ||
| def aSplit = a.split(':') | ||
| def bSplit = b.split(':') | ||
| def result = aSplit[0] <=> bSplit[0] |
There was a problem hiding this comment.
you could probably just do a toLowerCase() here and on line 28
Not sure if it's necessary, but following the patter of a few of the plugins
MarkEWaite
added
the
skip-artifact-caching-proxy
|
Closing for now. See the comment in #3606 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed to modify
check.groovyto remove the sorting because of uppercase issues. SInce we're now using spotless, we were getting into a doom loop sort ordering.Testing done
Submitter checklist