Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Office-365-Connector plugin #2893

Closed
wants to merge 2 commits into from
Closed

Adds Office-365-Connector plugin #2893

wants to merge 2 commits into from

Conversation

damianszczepanik
Copy link
Member

Testing done

Submitter checklist

@damianszczepanik damianszczepanik requested a review from a team as a code owner January 31, 2024 20:57
@alecharp
Copy link
Member

alecharp commented Feb 2, 2024

Hello @damianszczepanik. Thank you for your pull request.

I'm wondering if you could let us know if you run the PCT for this plugin on your end, and if so what was the result of it?

I see that the plugin is installed on about 6% of the known controllers and it has no dependent plugin. I'm wondering if this addition wouldn't be just increasing the cost of the build. Could you help us see the requirement to have this plugin in the bill of material? Thanks.

@jglick
Copy link
Member

jglick commented Feb 2, 2024

general recommendations FYI

@alecharp
Copy link
Member

alecharp commented Feb 2, 2024

I'm aware of that section. I agree that 6% is 18533 users so that it can qualify to the rule of

  • In the list of plugins with more than 10,000 (or 1,000) users

But still it seems low. Anyway, it would be nice to make sure that the PCT were ran locally so that it's not discovered at release time and we have to revert the addition of the plugin.

@damianszczepanik
Copy link
Member Author

Hello @damianszczepanik. Thank you for your pull request.

I'm wondering if you could let us know if you run the PCT for this plugin on your end, and if so what was the result of it?

Take a look at #2894 - this is the result of my local execution. I found the problem with upper case naming and I have submitted the issue. Results on Jenkins is same as on my local workstation, same test is failing. Given error stopped me so I don't know if PCT completes without issue.
Plugins runs with JDK 11 and 17 but does not with 21 (test fails when executing with JDK 21) so that might be a problem for PCT.

@damianszczepanik
Copy link
Member Author

Hello @damianszczepanik. Thank you for your pull request.

Could you help us see the requirement to have this plugin in the bill of material? Thanks.

I know how annoying maintaining version is - at lest for me who has a few Jenkins plugin. I wanted to update the plugin and spend some time on this so others don't have to. If you think that effort for having this plugin in BOM is high then I'm OK with closing this pull request.

@alecharp
Copy link
Member

alecharp commented Feb 3, 2024

Hello, we have notice that the plugin has Changelog file or any GitHub release. This means that if something new in the plugin that breaks the PCT run, we won't be able to easily detect what changed.

So far, I don't see the need to add this plugin to the BOM and I don't think it's a good idea.

@basil
Copy link
Member

basil commented Feb 4, 2024

I'm all for increasing the amount of testing we do on a regular basis, but this particular plugin cannot be included in the BOM until its tests pass on Java 21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants