Add Spotless to build #1926
Merged
Add Spotless to build #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Apr 1, 2023
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Conflicts with the changes that would be made by updatecli/generate-manifests.ps1, but that script has been disabled for quite some time and is effectively dead code that the maintainers ought to remove from this repository.
| @@ -33,7 +34,6 @@ if (settings.activeProfiles.any {it ==~ /^2[.][0-9]+[.]x$/}) { | |||
|
|
|||
| expected: $sortedDeps | |||
| """) | |||
| // TODO also check sorting of sample plugin dependencies | |||
There was a problem hiding this comment.
Finally implementing this long-standing TODO.
| <plugin> | ||
| <groupId>com.diffplug.spotless</groupId> | ||
| <artifactId>spotless-maven-plugin</artifactId> | ||
| <configuration> |
There was a problem hiding this comment.
The configuration has to be duplicated here unfortunately because sample-plugin extends from the plugin POM and not the root of the multi-module project. This is basically a hack as explained in #683.
MarkEWaite
approved these changes
Apr 1, 2023
MarkEWaite
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first line of defense when working on Groovy code is Spotless: if Spotless can't format it, then Groovy certainly won't be able to interpret it. "Testing" Groovy code with Spotless saves me time. So I am introducing Spotless in this repository. This PR applies Spotless to all
pom.xml, Java, and Groovy files in this repository. I recommend reviewing this with the Hide Whitespace changes feature enabled.