Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding jondaley to developer list since the plugin is currently up fo… #3894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jondaley
Copy link

adding jondaley to developer list since the plugin is currently up for adoption
@MarkEWaite - you seem to be the most recently active person? Just looking to help out. I use this plugin, and I'm upgrading my Jenkins installation when I saw this plugin was up for adoption, so willing to make sure it stays up and running for everyone.

Link to GitHub repository

https://github.com/jenkinsci/parameterized-trigger-plugin

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @jondaley

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

CD checklist (for submitters)

Reviewer checklist

There are IRC Bot commands for it.

@jondaley jondaley requested a review from a team as a code owner April 19, 2024 19:01
@NotMyFault
Copy link
Member

There are currently no unreviewed PRs or open issues you could address.

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Apr 19, 2024

@MarkEWaite - you seem to be the most recently active person? Just looking to help out. I use this plugin, and I'm upgrading my Jenkins installation when I saw this plugin was up for adoption, so willing to make sure it stays up and running for everyone.

Thanks very much for your willingness to help @jondaley . You could update the minimum required version of Jenkins by following the "Improve a plugin" tutorial, specifically the section on "Update Jenkins base version".

As justification to update the minimum Jenkins version of the plugin from 2.387.3 to 2.426.3, 80% of the installations of the most recent release (787.v665fcf2a_830b_ - released 5 months ago) are already using Jenkins 2.426.3. Jenkins 2.426.3 is also the first version to include the fix for SECURITY-3314.

That would probably also allow you to remove the explicit version number of the promoted builds plugin dependency and you might be able to remove the exclusions from that plugin declaration in the pom file. If you'd like my review on the pull request, just mention me with @MarkEWaite in either the pull request description or a comment.

@MarkEWaite
Copy link
Contributor

I am +1 for allowing @jondaley to adopt the plugin.

@MarkEWaite
Copy link
Contributor

@jondaley are you interested in creating the pull request to update the minimum required Jenkins version?

@jondaley
Copy link
Author

jondaley commented May 1, 2024

I can work on that. I wasn't sure if I was waiting for this change to get approved before I had access, etc.

I'll have to learn some about what the current dependencies are. I can't promise lots of time to this, but can do some.

@MarkEWaite
Copy link
Contributor

I'll have to learn some about what the current dependencies are. I can't promise lots of time to this, but can do some.

Thanks for your willingness. The "Improve a plugin" tutorial section to "Update Jenkins base version" should provide a good start. If you hit a bump or a surprise, feel free to open the pull request with whatever progress you've made. We'll then use any surprises you discover to improve the tutorial.

@jondaley
Copy link
Author

Sorry, I didn't realize you were aiming at getting this done quickly. I went to look at it today, but it looks like you already did it?

I looked through the other changes in the last month, and if you have enough time for working on this, that is great and I don't need to be involved. When I saw it up for adoption, I figured it was going to languish with no one.

@MarkEWaite
Copy link
Contributor

I needed to release the plugin after I understood the coupling between this plugin's promoted builds dependency and the dependency that that got plugin has on the promoted build plugin.

Would be great if you were willing to adopt the plugin and maintain it. I am a shadow maintainer only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants