Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python agent #15

Closed
wants to merge 1 commit into from
Closed

Add Python agent #15

wants to merge 1 commit into from

Conversation

basil
Copy link

@basil basil commented Jan 17, 2022

Like #14 but for Python. Tested locally with docker build.

CC @dduportal @timja

@dduportal
Copy link

Hello @basil , what is the reason to add this image? Is there a new project in jenkinsci that requires python?

@timja
Copy link
Member

timja commented Jan 18, 2022

Hello @basil , what is the reason to add this image? Is there a new project in jenkinsci that requires python?

I assume related to jenkinsci/packaging#239 (comment)

Copy link

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal, it looks really good technically but I'm going to block the PR for the following reasons:

@dduportal
Copy link

(for info, the build is not failing because of your change, but because of jenkins-infra/pipeline-library#287)

@dduportal
Copy link

Build fixed.

@basil
Copy link
Author

basil commented Jan 18, 2022

what is the reason to add this image? Is there a new project in jenkinsci that requires python?

There is no specific reason, and I had no particular project in mind. Python is my preferred scripting language, so I wanted to have the flexibility to use it for future projects or experiments. We also offer Ruby and JavaScript, so it seemed natural to also offer Python as a choice.

if this is needed for the molecule tests

It is not.

There is a work currently going on in jenkins-infra/packer-images#164 to move all the Dockerfile located in this repo into packer workload

But that PR is in draft state, while this PR is in non-draft state with a clean build and therefore ready to merge. So I see no reason why that PR should block this one.

@dduportal
Copy link

But that PR is in draft state, while this PR is in non-draft state with a clean build and therefore ready to merge. So I see no reason why that PR should block this one.

That's correct, the draft state of the other PR is not the reason to block adding a new kind of agent on the infrastructure: I poorly phrased my comment and I aplogize for that.

The reason I'm invoking to block this PR is that there is no reason for the infrastructure to support yet another dependency without a requirement that would have been discussed before at least for knowledge sharing. The current Jenkins infra allows to work with python when using a VM agent, so unless I'm missing something it is not a blocker.

Also this repository (jenkins-infra/docker-inbound-agent) is a fork of https://github.com/jenkinsci/jnlp-agents, to only aim at the jenkins-infra scope. Maintaining an exploding list of OS/image/dependencies is too much work for now that distract the team to fulfill their current obligation: hence it is a temporary "no" (unless, again, it is blocking).

This proposal to have a python agent would totally have a great value to be proposed to https://github.com/jenkinsci/jnlp-agents, which have a different set of reviewer, maintainers and users. If there is an image build from this, that could be a good feature request (to be raised in jenkins-infra/helpdesk) to add to ci.jenkins.io: does it sound a good idea?

@basil
Copy link
Author

basil commented Jan 18, 2022

I don't see a high maintenance burden associated with this PR, and I would like the flexibility of using this image in my experiments. I am not going to wrestle with you in PR comments. This will be my last comment in this thread. Take it or leave it: it's your choice.

@dduportal
Copy link

@dduportal dduportal closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants